Add gcc problem matcher to test.yml #7585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me - my only concern is licensing/permission as the code comes from somewhere else. I could imagine an argument that this is too simplistic for such concerns though. |
hugovk
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to python/cpython#18567, but I found there are extra spaces printed before the file name.
Would help find issues like #7497 (comment) faster.
The matcher is only run on a single Ubuntu job to prevent duplicate annotations; I found that the macOS jobs created two annotations per warning.
See nulano#25 for an example.
Not adding a problem matcher for MSVC yet because there are already many warnings that need to be fixed first to avoid noise.